-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] [wasi] Work around WASI's mmap implementation not returning aligned m… #92061
Conversation
…memory. Some code in sgen like sgen_los_free_object () expects the return address to be aligned. Hopefully fixes #88501 and others.
Oh I see this got backported. Unfortunately, I'm still seeing this failure in the 8.0 branch: Here's an example PR that hit it: #92374
|
Backport of #91761 to release/8.0
/cc @vargaz
Customer Impact
Enabling green CI when experimental feature is on - Only affects experimental WASI support. Mostly useful for fixing random CI failures like:
#86860
Testing
Tested by running a randomly failing test suite in a loop.
Risk
Low, only affects experimental WASI support.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.