[release/8.0] Update dependencies from dotnet/roslyn

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

• Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
• Build: 20230918.4
• Date Produced: September 19, 2023 2:57:05 AM UTC
• Commit: a19fe34b7266ab7638a12c2b54748d89d35a21a7
• Branch: refs/heads/main

• Updates:
  • Microsoft.CodeAnalysis: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
  • Microsoft.CodeAnalysis.CSharp: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4
  • Microsoft.Net.Compilers.Toolset: from 4.8.0-3.23462.10 to 4.8.0-3.23468.4

[carlossanlop]

@ericstj this roslyn deps update is broken. Who can take a look at source generator and interceptors-related failures?

The failure is:

/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project. [/__w/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Logging.Configuration.csproj::TargetFramework=net8.0]
##[error]/mnt/vss/_work/1/s/src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(33,10): error CS9137: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project.
 

[layomia]

@carlossanlop I'll push a fix.

[ericstj]

The fix here is to find all the projects with https://github.com/search?q=repo%3Adotnet%2Fruntime%20InterceptorsPreview&type=code

And make them instead use

<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>

Probably need the same in the PR that's pulling this Roslyn version into MAIN as well.

[ericstj]

Looks good to me. Thank you, @carlossanlop

[ericstj]

It looks like the test helpers also need to specify the new property:

runtime/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.Helpers.cs

Line 135 in 1f9764f

CSharpParseOptions parseOptions = new CSharpParseOptions(langVersion).WithFeatures(new[] { new KeyValuePair<string, string>("InterceptorsPreview", "") });

This is why the tests are failing here. It's because they are running the new compiler which doesn't seem to like having only the Feature set.

[ericstj]

@RikkiGibson can you tell us how our tests should set InterceptorsPreviewNamesapaces? I couldn't find a public API for this like there was for WithFeatures

I see, I think we can use Features API.

We need

CSharpParseOptions parseOptions = new CSharpParseOptions(langVersion).WithFeatures(new[] 
  { 
    new KeyValuePair<string, string>("InterceptorsPreview", ""),
    new KeyValuePair<string, string>("InterceptorsPreviewNamespaces", "Microsoft.Extensions.Configuration.Binder.SourceGeneration"),
  });

[ericstj]

LGTM

[ericstj]

This looks like it's good to go, if Roslyn would just stop building to update this PR 😆

[carlossanlop]

Still seeing one failure related to the interceptors, unfortunately. I'll take a look tomorrow.

The Tensors failure is unrelated, seems it was introduced here: #92245

@mmitche I haven't snapped rc2 due to this PR and a few other PRs that came in late, but will work on it tomorrow first thing in the morning.

[carlossanlop]

Ok the KnownBuildError just tagged this failure as known since May: #86532

So we can merge this finally, before the but adds more commits.

And the other failure is Tensors, unrelated to this, and will be fixed with #92270