Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] JIT: Extract all side effects of the index in optRemoveRangeCheck #92210

Merged
merged 1 commit into from
Sep 18, 2023

Commits on Sep 18, 2023

  1. JIT: Extract all side effects of the index in optRemoveRangeCheck

    optRemoveRangeCheck extracts only GTF_ASG from the bounds check. If the
    BOUNDS_CHECK is complex, that results in silently dropping side effects
    on the floor (see the example case).
    
    The ideal fix is that we should always extract all side effects from the
    index and length operands, however this has large regressions because
    the length typically has an ARR_LENGTH that we then extract. This PR
    instead has a surgical fix for the problem case that can be backported
    to .NET 8. It extracts all side effects from the index, but keeps
    extracting only GTF_ASG from the length to get around the issue
    mentioned above.
    
    Fix #91862
    jakobbotsch authored and github-actions committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    4b94cf4 View commit details
    Browse the repository at this point in the history