Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Workaround a C++/CLI bug involving DIMs (#89253)" #92234

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

tannergooding
Copy link
Member

This reverts commit 812492e.

This brings back in the expected support now that the C++/CLI fix is available in VS 17.8 Preview 2

image

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned tannergooding Sep 18, 2023
@ghost
Copy link

ghost commented Sep 18, 2023

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

This reverts commit 812492e.

This brings back in the expected support now that the C++/CLI fix is available in VS 17.8 Preview 2

image

Author: tannergooding
Assignees: tannergooding
Labels:

area-System.Numerics, new-api-needs-documentation

Milestone: -

@tannergooding
Copy link
Member Author

CC. @jeffhandley, @stephentoub

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great!

I'd like to get @mmitche or @marcpopMSFT to approve as well and give the green light on this merging into main and getting backported to RC2, with their affirmation that this won't trip up code flow to any repositories. I'll ping them in the appropriate channel to request they review.

@jeffhandley jeffhandley added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 18, 2023
@jeffhandley
Copy link
Member

We don't yet have VS 17.8 Preview 2 in place across our infrastructure, so this can't be merged into main yet, and we won't be able to accept this into RC2. The fix will have to wait for the GA milestone once that VS version flows through the queues.

@jeffhandley
Copy link
Member

VS 17.8.0 Preview 2 is now rolled out in the images that are used by dotnet/wpf. This PR is unblocked, can be merged into main, and then backported to release/8.0.

@jeffhandley jeffhandley merged commit aeb8c3c into dotnet:main Oct 18, 2023
@jeffhandley
Copy link
Member

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6564901021

@tannergooding tannergooding deleted the revert-89253 branch October 18, 2023 19:02
@ghost ghost locked as resolved and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants