-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Workaround a C++/CLI bug involving DIMs (#89253)" #92234
Conversation
This reverts commit 812492e.
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsThis reverts commit 812492e. This brings back in the expected support now that the C++/CLI fix is available in VS 17.8 Preview 2
|
CC. @jeffhandley, @stephentoub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Great!
I'd like to get @mmitche or @marcpopMSFT to approve as well and give the green light on this merging into main and getting backported to RC2, with their affirmation that this won't trip up code flow to any repositories. I'll ping them in the appropriate channel to request they review.
We don't yet have VS 17.8 Preview 2 in place across our infrastructure, so this can't be merged into |
VS 17.8.0 Preview 2 is now rolled out in the images that are used by dotnet/wpf. This PR is unblocked, can be merged into main, and then backported to |
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6564901021 |
This reverts commit 812492e.
This brings back in the expected support now that the C++/CLI fix is available in VS 17.8 Preview 2