[release/8.0-rc2] Make HostModel PEUtils always read/write little endian #92441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @vitek-karas, @agocke Issue DetailsBackport of #92392 to release/8.0-rc2 /cc @elinor-fung Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jkotas
approved these changes
Sep 21, 2023
jeffschwMSFT
approved these changes
Sep 21, 2023
|
Approved by Tactics via e-mail. |
elinor-fung
added
Servicing-approved
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #92392 to release/8.0-rc2
Fixes #92344
/cc @elinor-fung
Customer Impact
Functions used for creating an apphost did not properly handle endianness. This results in a failure on non-little-endian systems to install tools (see #92344) or cross-build Windows GUI application. This was a regression in RC1.
Testing
Updated tests to explicitly call one of the problematic functions (issue would still only have manifested when run on non-little-endian system). Manual.
Risk
Low. The fix maintains the existing logic while adding checks for endianness in four places.