[browser] mono runtime already exited with 0 - silence WS #92479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
pavelsavara
changed the title
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
approved these changes
Sep 22, 2023
radical
approved these changes
Sep 22, 2023
radical
reviewed
Sep 22, 2023
| @@ -58,17 +58,20 @@ export function ws_wasm_create(uri: string, sub_protocols: string[] | null, rece | |||
| ws.binaryType = "arraybuffer"; | |||
| const local_on_open = () => { | |||
| if (ws[wasm_ws_is_aborted]) return; | |||
| if (loaderHelpers.is_exited()) return; | |||
There was a problem hiding this comment.
Should this be before if (ws[wasm_ws_is_aborted]) return too?
There was a problem hiding this comment.
doesn't really matter.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt on #89425