Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mono] Disabled failing tests on Mono Android and interpreter lanes to keep CI green #92728

Merged
merged 2 commits into from
Oct 5, 2023
Merged

[Mono] Disabled failing tests on Mono Android and interpreter lanes to keep CI green #92728

merged 2 commits into from
Oct 5, 2023

Conversation

fanyang-mono
Copy link
Member

@fanyang-mono fanyang-mono commented Sep 27, 2023 •
edited
Loading

Trying to make runtime-extra-platforms greener

@ghost ghost assigned fanyang-mono Sep 27, 2023
@ghost
Copy link

ghost commented Sep 27, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: fanyang-mono
Assignees: fanyang-mono
Labels:

area-Infrastructure-mono
Milestone: -

@SamMonoRT
Copy link
Member

Trying to make runtime-extra-platforms greener

Just to clarify, we have the interpreter lanes running in extra-platforms or just Android emulator ones, and you updated interp lane too.

@fanyang-mono
Copy link
Member Author

fanyang-mono commented Sep 27, 2023 •
edited
Loading

Yes, I am disabling one test on interpreter lane as well, per @kotlarmilos requested.

mono monointerpreter Pri0 Runtime Tests Run linux arm64 release is the interpreter lane runs in extra-platforms.

@SamMonoRT
Copy link
Member

Yes, I am disabling one test on interpreter lane as well, per @miloszkukla requested.

mono monointerpreter Pri0 Runtime Tests Run linux arm64 release is the interpreter lane runs in extra-platforms.

you meant @kotlarmilos

kotlarmilos
kotlarmilos approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@kotlarmilos kotlarmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will take a look at the interpreter test.

@build-analysis build-analysis bot mentioned this pull request Sep 27, 2023
Closed
@fanyang-mono
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Sep 28, 2023
Open
Open
Closed
Closed
Closed
@kotlarmilos
Copy link
Member

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fanyang-mono
Copy link
Member Author

The tests that this PR intended to disable are not failing on CI anymore.

@fanyang-mono fanyang-mono merged commit 9dfbb61 into dotnet:main Oct 5, 2023
138 of 150 checks passed
This was referenced Oct 5, 2023
Closed
Closed
@radical radical mentioned this pull request Oct 6, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kotlarmilos kotlarmilos kotlarmilos approved these changes

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@fanyang-mono fanyang-mono

Labels
area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanyang-mono @SamMonoRT @kotlarmilos