[release/8.0] Fix deadlock in EventPipeEventDispatcher #92912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jeffschwMSFT
approved these changes
Oct 3, 2023
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 8.0.x
lateralusX
approved these changes
Oct 3, 2023
rbhanda
added
Servicing-approved
Contributor
|
CI failure is unrelated. Not sure why KnownBuildError did not link it: #92944 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #92806 to release/8.0
/cc @tommcdon @davmason
Customer Impact
Fixes a deadlock issue #92236 caught in CI.
Taking
m_dispatchControlLockaround the call toEventPipeInternal.Disableleads to a potential deadlock where one thread is holding theEventListenersLockand trying to getm_dispatchControlLockand the disable thread is holdingm_dispatchControlLockand trying to getEventListenersLockas part of handling the disable command.This switches to using volatile reads and writes (just for the observability part) to make the dispatch loop wait until
SignalSessionhas been called before calling in toDisableTesting
Validated eventpipe test no longer hangs
Risk
Low