Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISC-V] Use standard NaNs in FP ops for cross-compiling RISC-V on x86 #93098

Merged
merged 1 commit into from
Oct 6, 2023
Merged

[RISC-V] Use standard NaNs in FP ops for cross-compiling RISC-V on x86 #93098

merged 1 commit into from
Oct 6, 2023

Conversation

tomeksowi
Copy link
Contributor

Use positive NaNs on RISC-V for FP ops crossgen-evaluated when host is x86.

Split from #92934

Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @gbalykov @clamp03 @sirntar @yurai007

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 6, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 6, 2023
@ghost
Copy link

ghost commented Oct 6, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Use positive NaNs on RISC-V for FP ops crossgen-evaluated when host is x86.

Split from #92934

Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @gbalykov @clamp03 @sirntar @yurai007

Author: tomeksowi
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@tomeksowi tomeksowi mentioned this pull request Oct 6, 2023
Merged
@tomeksowi
Copy link
Contributor Author

Build failures seem to be caused by problems with remote downloads, not the code change itself.

@build-analysis build-analysis bot mentioned this pull request Oct 6, 2023
Open
5 tasks
@tomeksowi tomeksowi marked this pull request as ready for review October 6, 2023 12:33
@tomeksowi
Copy link
Contributor Author

@jakobbotsch PR ready for review

@jakobbotsch jakobbotsch merged commit b0a476c into dotnet:main Oct 6, 2023
@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Oct 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@tomeksowi tomeksowi

Labels
arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomeksowi @jakobbotsch @clamp03