-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crossgen2 invocation error under sourcebuild #93450
Conversation
Tagging subscribers to this area: @hoyosjs Issue DetailsUnsure if this is the right direction but wanted to open the PR to make some progress on unblocking the installer PR. See failure in dotnet/installer#17524
@jkoritzinsky why do we invoke crossgen2.dll manually here instead of going through the SDK integration?
|
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
We invoke it manually as we never moved this project to use the SDK integration. Also the SDK integration expects there to be a runtime pack, which CoreLib doesn't have. The crossgen2_inbuild project targets NetCoreAppToolCurrent, so that's where the 8.0 version number comes from. |
@jkoritzinsky and I talked about this offline and he believes that this might only fix the first point of failure. We believe that a better path going forward would be updating |
I've logged #93666 to track the issue. |
Unsure if this is the right direction but wanted to open the PR to make some progress on unblocking the installer PR.
See failure in dotnet/installer#17524
@jkoritzinsky why do we invoke crossgen2.dll manually here instead of going through the SDK integration?
One more question, why does runtimeconfig.json list
8.0.0-preview.7.23375.6
? Shouldn't we require9.0.0-alpha.1.23470.17
during source build?