Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep using RO metadata after creating IMetaDataImporter for PDB reading #93760

Closed
wants to merge 1 commit into from

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Oct 19, 2023

This change allows the runtime to keep using the read-only view of the metadata interfaces
after the conversion of it has been requested to back calls into the classic PDB parser.
Swapping of the cached RW converted view it will be deferred until some other path (e.g.
profiler, MD emit) requests a RW view of it.

Fixes #90563

@carlossanlop
Copy link
Member

When ready, please send an email to Tactics requesting approval. Friendly reminder that we need this merged before 4pm tomorrow Friday 20th to ensure it goes into GA.

@jkotas
Copy link
Member

jkotas commented Oct 20, 2023

@hoyosjs We should get this into main first and let it bake there for at one or two weeks before backporting the change to servicing.

@hoyosjs
Copy link
Member Author

hoyosjs commented Oct 20, 2023

That's the idea. I just had created this against 8 originally, so I opened the draft to get some CI coverage. Need to create the main PR. This won't go in before 8.0 releases for sure.

@carlossanlop
Copy link
Member

@hoyosjs please target the release/8.0-staging branch. It has been created now.

@carlossanlop
Copy link
Member

Friendly reminder: If you'd like this to be included in the December release, please merge it before Tuesday November 14th EOD (Code Complete).

@ghost ghost closed this Dec 9, 2023
@ghost
Copy link

ghost commented Dec 9, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants