Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: stop creating gc poll blocks in morph #93816

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

AndyAyersMS
Copy link
Member

Instead, mark the block as needing a GC poll and add one later in the normal GC poll insertion phase. This only impacts x86.

This change also stops creating inline GC polls for these cases in unoptimized code.

Instead, mark the block as needing a GC poll and add one later in the normal
GC poll insertion phase. This only impacts x86.

This change also stops creating inline GC polls for these cases in unoptimized
code.
@ghost ghost assigned AndyAyersMS Oct 21, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 21, 2023
@ghost
Copy link

ghost commented Oct 21, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Instead, mark the block as needing a GC poll and add one later in the normal GC poll insertion phase. This only impacts x86.

This change also stops creating inline GC polls for these cases in unoptimized code.

Author: AndyAyersMS
Assignees: AndyAyersMS
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS
Copy link
Member Author

@jakobbotsch PTAL
cc @dotnet/jit-contrib

@AndyAyersMS AndyAyersMS merged commit 52bd95c into dotnet:main Oct 22, 2023
129 checks passed
@EgorBo
Copy link
Member

EgorBo commented Oct 22, 2023

Assert failure(PID 29 [0x0000001d], Thread: 217 [0x00d9]): Assertion failed 'doesMethodHaveRecursiveTailcall()' in 'System.Reflection.SignatureType:GetHashCode():int:this' during 'Morph - Global' (IL size 7; hash 0xe30863bc; Instrumented Tier1)

    File: /__w/1/s/src/coreclr/jit/morph.cpp Line: 7459
    Image: /root/helix/work/correlation/dotnet

can it be related? (jitstress) can be also pre-existing issue or my PR

@jakobbotsch
Copy link
Member

The assert was added in #93764. I've opened #93844 for it.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants