Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Improve forwardsub for small types #94631

Merged
merged 1 commit into from
Nov 12, 2023
Merged

JIT: Improve forwardsub for small types #94631

merged 1 commit into from
Nov 12, 2023

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Nov 11, 2023 •
edited
Loading

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 11, 2023
@ghost ghost assigned EgorBo Nov 11, 2023
@ghost
Copy link

ghost commented Nov 11, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Nov 11, 2023
Closed
@EgorBo
Copy link
Member Author

EgorBo commented Nov 11, 2023 •
edited
Loading

@jakobbotsch @SingleAccretion thanks for the suggestion for a better fix! Is there anything else needed here then? This should fix some of the regressions I hit in #94621, but I want to land it separately to make that one zero-diff (ideally). example:

image

Diffs https://dev.azure.com/dnceng-public/public/_build/results?buildId=466832&view=ms.vss-build-web.run-extensions-tab

cc @dotnet/jit-contrib

@EgorBo EgorBo marked this pull request as ready for review November 11, 2023 18:41
jakobbotsch
jakobbotsch approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- please fix the PR title and commit message

@jakobbotsch
Copy link
Member

Should probably run jitstress and Fuzzlyn too.

@EgorBo
Copy link
Member Author

EgorBo commented Nov 11, 2023

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, fuzzlyn

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@EgorBo EgorBo changed the title CI test, fwdsub JIT: Improve forwardsub for small types Nov 11, 2023
@EgorBo
Copy link
Member Author

EgorBo commented Nov 12, 2023

@jakobbotsch have you seen Fuzzlyn failures like this one https://dev.azure.com/dnceng-public/public/_build/results?buildId=466925&view=ms.vss-build-web.run-extensions-tab ?

@jakobbotsch
Copy link
Member

@jakobbotsch have you seen Fuzzlyn failures like this one https://dev.azure.com/dnceng-public/public/_build/results?buildId=466925&view=ms.vss-build-web.run-extensions-tab ?

No, I haven't seen that before. I checked and it is hitting an assert with and without this change, so it is not related to this PR.

Assert failure(PID 15296 [0x00003bc0], Thread: 13572 [0x3504]): Assertion failed 'codeSize <= MAX_PROLOG_SIZE_BYTES' in 'Program:.cctor()' during 'Emit code' (IL size 10191; hash 0x02c770ad; FullOpts)

    File: C:\dev\dotnet\runtime\src\coreclr\jit\unwindarmarch.cpp Line: 834
    Image: H:\dotnet\runtime\artifacts\tests\coreclr\windows.arm64.Checked\Tests\Core_Root_base\corerun.exe

(Looks like Fuzzlyn should be looking at inner exceptions when it sees System.TypeInitializationException to be able to extract that assertion failure from it.)

@EgorBo EgorBo merged commit e37b853 into dotnet:main Nov 12, 2023
237 of 242 checks passed
@EgorBo EgorBo deleted the improve-fwdsub branch November 12, 2023 20:46
This was referenced Nov 14, 2023
Closed
Closed
@cincuranet
Copy link
Contributor

cincuranet commented Nov 16, 2023 •
edited
Loading

Regression in System.Collections.ContainsTrueComparer<Int32>.FrozenSet:

@cincuranet cincuranet mentioned this pull request Nov 21, 2023
Closed
@cincuranet
Copy link
Contributor

cincuranet commented Nov 21, 2023 •
edited
Loading

Some improvements:

@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EgorBo @jakobbotsch @cincuranet