Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UInt128: Throw DivideByZeroException when divisor is 0 #94640

Merged
merged 2 commits into from
Nov 13, 2023
Merged

UInt128: Throw DivideByZeroException when divisor is 0 #94640

merged 2 commits into from
Nov 13, 2023

Conversation

manandre
Copy link
Contributor

Fixes #94593

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 11, 2023
@ghost
Copy link

ghost commented Nov 11, 2023

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #94593

Author: manandre
Assignees: -
Labels:

area-System.Numerics
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Nov 12, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Nov 12, 2023
Closed
@tannergooding
Copy link
Member

There is a conflict that needs resolving before this can be merged.

@manandre manandre force-pushed the u-int128-divide-by-zero branch from daf2a67 to 4631b7b Compare November 13, 2023 18:11
@manandre
Copy link
Contributor Author

@tannergooding Commits rebased. The conflict was only about some test files moved.
See #94644

@tannergooding tannergooding merged commit 1e4d36d into dotnet:main Nov 13, 2023
173 of 175 checks passed
@manandre manandre deleted the u-int128-divide-by-zero branch November 14, 2023 07:25
@danmoseley
Copy link
Member

thanks @manandre for the contribution!

@build-analysis build-analysis bot mentioned this pull request Nov 14, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley left review comments

@skyoxZ skyoxZ skyoxZ left review comments

@tannergooding tannergooding tannergooding approved these changes

Assignees
No one assigned
Labels
area-System.Numerics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

{U}Int128 divided by 0 throws wrong exception type
4 participants
@manandre @tannergooding @danmoseley @skyoxZ