JIT: enable complementary jtrue assertions for cross-block local ap #94741
Conversation
Now that we can propagate assertions across block boundaries we can generate assertions for true/false branch conditions and propagate them along the corresponding edges. Contributes to dotnet#93246.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsNow that we can propagate assertions across block boundaries we can generate assertions for true/false branch conditions and propagate them along the corresponding edges. Contributes to #93246.
|
|
@jakobbotsch PTAL This doesn't have any impact unless cross-block is enabled. When it is I see this sort of impact It's possible that enabling "if true" copy prop based on 
and a small TP hit 
ts.
|
src/coreclr/jit/morph.cpp
Outdated
| if (pred->KindIs(BBJ_COND) && (pred->NumSucc() == 2) && (block == pred->GetJumpDest())) | ||
| { | ||
| JITDUMP("Using `if true` assertions from pred " FMT_BB "\n", pred->bbNum); | ||
| assertionsOut = pred->bbAssertionGen; |
There was a problem hiding this comment.
Consider adding new members to the unions to give these sets more proper names.
Now that we can propagate assertions across block boundaries we can generate assertions for true/false branch conditions and propagate them along the corresponding edges.
Contributes to #93246.