Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TimeSpan with RangeAttribute in Options validation source generator #94798

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Support TimeSpan with RangeAttribute in Options validation source generator #94798

merged 1 commit into from
Nov 16, 2023

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Nov 15, 2023

@ghost ghost assigned tarekgh Nov 15, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 15, 2023
@tarekgh tarekgh added area-Extensions-Options source-generator Indicates an issue with a source generator feature labels Nov 15, 2023
@ghost
Copy link

ghost commented Nov 15, 2023

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

#94119

Author: tarekgh
Assignees: tarekgh
Labels:

area-Extensions-Options, source-generator, needs-area-label
Milestone: -

@tarekgh tarekgh added this to the 9.0.0 milestone Nov 15, 2023
@tarekgh
Copy link
Member Author

tarekgh commented Nov 15, 2023

This is a candidate to port to 8.0 servicing.

CC @ericstj @eerhardt

@tarekgh tarekgh removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 15, 2023
eiriktsarpalis
eiriktsarpalis approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one question I had.

@eerhardt
Copy link
Member

I tested this fix with the https://github.com/dotnet/extensions/tree/main/src/Libraries/Microsoft.Extensions.Http.Resilience library (which uses the Options Validation source generator) and I'm able to successfully publish a Native AOT application using the library built with this fix with no AOT warnings.

Thanks, @tarekgh!

@eerhardt eerhardt mentioned this pull request Nov 16, 2023
Closed
@tarekgh tarekgh merged commit 0b073c3 into dotnet:main Nov 16, 2023
109 checks passed
@tarekgh
Copy link
Member Author

tarekgh commented Nov 16, 2023

/backport to release/8.0-staging

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/6894206422

@github-actions github-actions bot mentioned this pull request Nov 16, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@tarekgh tarekgh

Labels
area-Extensions-Options source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tarekgh @eerhardt @eiriktsarpalis