Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in testenv for cross-block local assertion prop #94978

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

AndyAyersMS
Copy link
Member

Also enable for the libraries pgo run.

Also enable for the libraries pgo run.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 19, 2023
@ghost ghost assigned AndyAyersMS Nov 19, 2023
@AndyAyersMS
Copy link
Member Author

@dotnet/jit-contrib PTAL

@AndyAyersMS AndyAyersMS added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 19, 2023
@ghost
Copy link

ghost commented Nov 19, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Also enable for the libraries pgo run.

Author: AndyAyersMS
Assignees: AndyAyersMS
Labels:

area-CodeGen-coreclr, needs-area-label

Milestone: -

@AndyAyersMS
Copy link
Member Author

/azp run runtime-jit-experimental

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -242,6 +242,7 @@ jobs:
- jitosr_stress_random
- syntheticpgo
- syntheticpgo_blend
- jitcrossblocklocalassertionprop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we ought to have a runtime-jit-experimental variant for libraries

@AndyAyersMS
Copy link
Member Author

Going to merge this despite red build analysis, novel failures are in experimental pipeline.

@AndyAyersMS AndyAyersMS merged commit 4689814 into dotnet:main Nov 27, 2023
157 of 166 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants