Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][debugger] If debugger is disconnected but vm is not exited restart the debugger thread #95266

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Nov 27, 2023

Fixing wrong check.

Fixes #95256

@ghost
Copy link

ghost commented Nov 27, 2023

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixing wrong check.

Author: thaystg
Assignees: thaystg
Labels:

area-Debugger-mono

Milestone: -

@thaystg thaystg requested a review from lambdageek November 27, 2023 14:19
@lambdageek
Copy link
Member

By the way @thaystg there's a call to mono_debugger_agent_receive_and_process_command on WASI that doesn't check the return value. Probably should make a separate issue for it, but there's probably an issue there, too.

#ifdef HOST_WASI
resumed_from_wasi = FALSE;
while (suspend_policy != SUSPEND_POLICY_NONE && !resumed_from_wasi)
{
GET_DEBUGGER_TLS();
tls->really_suspended = TRUE;
mono_debugger_agent_receive_and_process_command ();
}
#endif

@lambdageek
Copy link
Member

We should backport

@thaystg
Copy link
Member Author

thaystg commented Nov 27, 2023

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7007052573

@thaystg thaystg merged commit 2158031 into dotnet:main Nov 28, 2023
109 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mono debug component not able to re-connect after disconnect
2 participants