-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Fix debug URL in lauchSettings.json in wasmbrowser template #95392
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsRegression from wasmbrowser template migration to WebAssembly SDK
|
If the implementation is not changed the URL was correct: _framework is not mapped in the wasmbrowser template. |
After a long chat with @maraf , approving! :) |
/backport to release/8.0-staging |
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7036833502 |
I would love to read the explanation too. |
@thaystg Does CTI test for this scenario? |
Probably no. |
@maraf: New browser template based on WebAssembly SDK has a copy of blazor's dev server in wasmapphost. So we should use this URL with _framework/debug. We are not using this code anymore: |
ok, thanks for sharing that. We should add at least one test for debugging wasmbrowser the way an IDE might connect to it. Maybe for blazor after that? |
Do you mean an automatic test? |
yeah, in DebuggerTestSuite. Just a simple one that validates that we can connect, and step or something. |
Should we delete the dead code ? |
We can do it once we drop support for older template. I hope to unite browser & console template & runtime tests on Wasm SDK in 9 and remove the former bundler |
Regression from wasmbrowser template migration to WebAssembly SDK
Tested manually be creating a project from updated template and launched from Visual studio using F5
Fixes #95391