Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Fix debug URL in lauchSettings.json in wasmbrowser template #95392

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Nov 29, 2023

Regression from wasmbrowser template migration to WebAssembly SDK
Tested manually be creating a project from updated template and launched from Visual studio using F5
Fixes #95391

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Nov 29, 2023
@maraf maraf added this to the 9.0.0 milestone Nov 29, 2023
@maraf maraf self-assigned this Nov 29, 2023
@ghost
Copy link

ghost commented Nov 29, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Regression from wasmbrowser template migration to WebAssembly SDK
Tested manually be creating a project from updated template and launched from Visual studio using F5
Fixes #95391

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono, os-browser

Milestone: 9.0.0

@maraf
Copy link
Member Author

maraf commented Nov 29, 2023

@radical @thaystg Is F5 suppose to work for console template? I'm getting
image

@thaystg
Copy link
Member

thaystg commented Nov 29, 2023

If the implementation is not changed the URL was correct:
https://github.com/dotnet/runtime/blob/f66c1c15409ff505ba55f8fdf86bc5c041bf47a3/src/mono/wasm/host/WebServerStartup.cs#L132C1-L132C1

_framework is not mapped in the wasmbrowser template.

@thaystg
Copy link
Member

thaystg commented Nov 29, 2023

After a long chat with @maraf , approving! :)
Thanks for the explanation.

@maraf maraf merged commit ac00702 into dotnet:main Nov 29, 2023
22 checks passed
@maraf
Copy link
Member Author

maraf commented Nov 29, 2023

/backport to release/8.0-staging

@maraf maraf deleted the BrowserTemplateDebugUrl branch November 29, 2023 18:19
Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7036833502

@radical
Copy link
Member

radical commented Nov 29, 2023

After a long chat with @maraf , approving! :) Thanks for the explanation.

I would love to read the explanation too.

@radical
Copy link
Member

radical commented Nov 29, 2023

@thaystg Does CTI test for this scenario?

@thaystg
Copy link
Member

thaystg commented Nov 29, 2023

Probably no.
Not sure who should help us to ask them to test. Maybe @mkArtakMSFT ?

@thaystg
Copy link
Member

thaystg commented Nov 29, 2023

After a long chat with @maraf , approving! :) Thanks for the explanation.

I would love to read the explanation too.

@maraf: New browser template based on WebAssembly SDK has a copy of blazor's dev server in wasmapphost.

So we should use this URL with _framework/debug.

We are not using this code anymore:
https://github.com/dotnet/runtime/blob/f66c1c15409ff505ba55f8fdf86bc5c041bf47a3/src/mono/wasm/host/WebServerStartup.cs#L132C1-L132C1

@radical
Copy link
Member

radical commented Nov 29, 2023

ok, thanks for sharing that. We should add at least one test for debugging wasmbrowser the way an IDE might connect to it.

Maybe for blazor after that?

@thaystg
Copy link
Member

thaystg commented Nov 29, 2023

Do you mean an automatic test?

@radical
Copy link
Member

radical commented Nov 29, 2023

Do you mean an automatic test?

yeah, in DebuggerTestSuite. Just a simple one that validates that we can connect, and step or something.

@pavelsavara
Copy link
Member

We are not using this code anymore: https://github.com/dotnet/runtime/blob/f66c1c15409ff505ba55f8fdf86bc5c041bf47a3/src/mono/wasm/host/WebServerStartup.cs#L132C1-L132C1

Should we delete the dead code ?

@maraf
Copy link
Member Author

maraf commented Dec 1, 2023

Should we delete the dead code ?

We can do it once we drop support for older template. I hope to unite browser & console template & runtime tests on Wasm SDK in 9 and remove the former bundler

@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasmbrowser template has wrong inspecturi
4 participants