Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable EventSource tests #95498

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Disable EventSource tests #95498

merged 1 commit into from
Dec 2, 2023

Conversation

davmason
Copy link
Member

@davmason davmason commented Dec 1, 2023

The manifest generation tests use lots of sleeps and are problematic with longer running targets, i.e. jitstress and gcstress.

The ETW tests keep failing because the process is not elevated even though we should be guarding against that, further research is necessary to determine what the issue is. For now we should disable these tests to get them off the blocking CI list

@ghost
Copy link

ghost commented Dec 1, 2023

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

The manifest generation tests use lots of sleeps and are problematic with longer running targets, i.e. jitstress and gcstress.

The ETW tests keep failing because the process is not elevated even though we should be guarding against that, further research is necessary to determine what the issue is. For now we should disable these tests to get them off the blocking CI list

Author: davmason
Assignees: -
Labels:

area-System.Diagnostics.Tracing

Milestone: 9.0.0

@@ -30,7 +30,7 @@ public partial class TestsManifestGeneration

/// ETW only works with elevated process
[ConditionalFact(nameof(IsProcessElevatedAndNotWindowsNanoServerAndRemoteExecutorSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/48798", typeof(PlatformDetection), nameof(PlatformDetection.IsX86Process))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/48798")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any non win-x86 failures in #48798. Why disable it on other platforms too?

@tommcdon
Copy link
Member

tommcdon commented Dec 1, 2023

I agree - disabling the manifest generation ETW tests while we resolve test parallelization and timing issues will help reduce unnecessary noise on PR's and daily builds.

@davmason davmason merged commit aea4de9 into dotnet:main Dec 2, 2023
108 of 111 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants