-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement more APIs in new TypeBuilder, fix bugs found during testing #95753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @dotnet/area-system-reflection-emit Issue Details
|
jkotas
reviewed
Dec 8, 2023
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ModuleBuilderImpl.cs
Show resolved
Hide resolved
jkotas
reviewed
Dec 8, 2023
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ModuleBuilderImpl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Dec 8, 2023
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/PseudoCustomAttributesData.cs
Outdated
Show resolved
Hide resolved
buyaa-n
force-pushed
the
implement_apis
branch
from
December 8, 2023 19:54
4503569
to
0d23a23
Compare
jkotas
reviewed
Dec 8, 2023
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/PseudoCustomAttributesData.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Dec 8, 2023
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/PseudoCustomAttributesData.cs
Show resolved
Hide resolved
jkotas
reviewed
Dec 8, 2023
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Dec 9, 2023
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ModuleBuilderImpl.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ModuleBuilderImpl.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
buyaa-n
force-pushed
the
implement_apis
branch
from
December 11, 2023 04:43
2ffb83a
to
edd9739
Compare
steveharter
reviewed
Dec 11, 2023
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ModuleBuilderImpl.cs
Show resolved
Hide resolved
steveharter
reviewed
Dec 11, 2023
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/PseudoCustomAttributesData.cs
Show resolved
Hide resolved
steveharter
reviewed
Dec 11, 2023
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs
Outdated
Show resolved
Hide resolved
steveharter
reviewed
Dec 11, 2023
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs
Outdated
Show resolved
Hide resolved
This was referenced Dec 12, 2023
…instead of 2 List of <MethodInfo>s
buyaa-n
force-pushed
the
implement_apis
branch
from
December 18, 2023 23:44
3eca7ce
to
0c6b4d7
Compare
buyaa-n
force-pushed
the
implement_apis
branch
from
December 19, 2023 00:06
0c6b4d7
to
7fbc17b
Compare
steveharter
reviewed
Dec 20, 2023
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs
Outdated
Show resolved
Hide resolved
steveharter
approved these changes
Dec 21, 2023
Build failure unrelated and reported |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefineMethodOverrideCore(...)
,GetInterfaceMap(...)
,GetMethods(...)
,GetMethodImpl(...)
,IsAssignableFrom(...)
overrides and a few other related APIsDefineMethodOverrideCore(...)
was happening during type creation, moved the validations to the corresponding API call and throwingArgumentException
instead ofTypeLoadException
MethodAttributes.RTSpecialName
for constructors (in addition toMethodAttributes.SpecialName
)AssemblyBuilderB.Save
test from mono and fixed bugs foundSignatureCallingConvention
of a methodMarshalAsAttribute
attribute withUnmanagedType.CustomMarshaler
field typeContributes to #92975