Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Set certificate as a dependency of private key handles #95924

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

vcsjones
Copy link
Member

The SafeSecKeyRefHandle needs the certificate and its keychain alive for as long as it exists on macOS.

This sets the certificate, not the identity, as a parent handle of the private key.

Fixes #94959

@ghost
Copy link

ghost commented Dec 12, 2023

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

The SafeSecKeyRefHandle needs the certificate and its keychain alive for as long as it exists on macOS.

This sets the certificate, not the identity, as a parent handle of the private key.

Fixes #94959

Author: vcsjones
Assignees: -
Labels:

area-System.Security

Milestone: -

@bartonjs bartonjs merged commit 3108eda into dotnet:main Jan 2, 2024
111 checks passed
@vcsjones vcsjones deleted the macos-x509-cert-lifetimes branch January 2, 2024 23:33
@tore-hammervoll
Copy link

Any news on when this fix will be released? This is currently blocking the upgrade from .Net 6/7 to .Net 8, as we can't develop on macOS.

@vcsjones
Copy link
Member Author

@tore-hammervoll currently this is only fixed for .NET 9. Can you open a new issue asking that this fix be back ported to .NET 8, and indicate that it is preventing you from moving to .NET 8?

@tore-hammervoll
Copy link

@vcsjones I never got around to making that issue. Thanks for getting this fix backported so quickly!

@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jose.JoseException: Unable to sign content
4 participants