JIT: Canonicalize newly recognized loops #96751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create preheaders for all loops, not just loops recognized by old loop finding.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsCreate preheaders for all loops, not just loops recognized by old loop finding.
|
This was referenced Jan 10, 2024
2 tasks
Loops with headers at the beginning of handlers were not handled correctly; those should get preheaders that become the new handler begin.
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
cc @dotnet/jit-contrib PTAL @BruceForstall libraries-jitstres failure is #96715. superpmi-diffs failure looks like an infra issue. NAOT failure is #94728. |
BruceForstall
approved these changes
Jan 10, 2024
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
Create preheaders for all loops, not just loops recognized by old loop finding. Requires adding support for creating preheaders when the loop header is the beginning of a handler block, which requires updating the EH table (so we switch to fgExtendEHRegionBefore).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create preheaders for all loops, not just loops recognized by old loop finding. Requires adding support for creating preheaders when the loop header is the beginning of a handler block, which requires updating the EH table (so we switch to
fgExtendEHRegionBefore).