Don't copy runner to test output during regular builds #96826
Conversation
The test runner is not required for local test execution, but is needed for helix (today). In the future we should try to change helix to not expect the runner in the output directory, but instead as a correlation payload.
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned
| <None Remove="$(Pkgxunit_runner_visualstudio)\build\netcoreapp2.1\xunit.runner.reporters.netcoreapp10.dll" /> | ||
| <ItemGroup> | ||
| <None Remove="$(Pkgxunit_runner_visualstudio)\build\net462\xunit.abstractions.dll" /> | ||
| <None Remove="$(Pkgxunit_runner_visualstudio)\build\net6.0\xunit.abstractions.dll" /> |
There was a problem hiding this comment.
This changes every other year and unfortunately msbuild doesn't emit a warning/error when an item remove operation fails. Please add a target that errors out when one of those items aren't found.
There was a problem hiding this comment.
Ok, this is about to go away anyhow since I see you worked to get the original issue fixed. I refinef this workaround a bit (turns out it is only needed on netfx the netcore props never copied it) until we can pick up a new release of xunit. IMO the bigger issue to fix here is the dotnet test - I just noticed the double write problem was not fixed and corrected it while I was here - I'd like to merge this rather than wait for the new Xunit.
am11
added
area-Infrastructure-libraries
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsFixes #94183 The test runner is not required for local test execution, but is needed for helix (today). In the future we should try to change helix to not expect the runner in the output directory, but instead as a correlation payload.
|
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
|
Note that this PR (as with any double-write fix) will require two consecutive incremental builds or a git clean to get the fix. Sharing that here in case folks see funny behavior after this fix. It had me scratching my head briefly until I realized what was going on - incremental clean was deleting files that I deduplicated. |
* Don't copy runner to test output during regular builds The test runner is not required for local test execution, but is needed for helix (today). In the future we should try to change helix to not expect the runner in the output directory, but instead as a correlation payload. * Refine xunit 1651 workaround until we can pick up the fix * Update eng/testing/xunit/xunit.console.targets Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com> * Update xunit.console.targets --------- Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Fixes #94183
The test runner is not required for local test execution, but is needed for helix (today). In the future we should try to change helix to not expect the runner in the output directory, but instead as a correlation payload.