JIT: remove size contribution to perf score #97069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the perf score a pure performance metric. Size is emitted as a separate metric, so clients interested in a metric that is some combination of size and speed can do their own computations based on these two values. Resolves dotnet#96878.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsKeep the perf score a pure performance metric. Size is emitted as a separate metric, so clients interested in a metric that is some combination of size and speed can do their own computations based on these two values. Resolves #96878.
|
|
@dotnet/jit-contrib FYI |
jakobbotsch
approved these changes
Jan 17, 2024
Comment on lines
-2008
to
-2010
| compiler->info.compPerfScore += ((double)compiler->info.compTotalHotCodeSize * (double)PERFSCORE_CODESIZE_COST_HOT); | ||
| compiler->info.compPerfScore += | ||
| ((double)compiler->info.compTotalColdCodeSize * (double)PERFSCORE_CODESIZE_COST_COLD); |
There was a problem hiding this comment.
You should remove the definitions of PERFSCORE_CODESIZE_COST_HOT / PERFSCORE_CODESIZE_COST_COLD, which will be no longer used.
|
Odd the CI never ran anything... |
BruceForstall
approved these changes
Jan 18, 2024
|
NAOT failure was #94728. |
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
Keep the perf score a pure performance metric. Size is emitted as a separate metric, so clients interested in a metric that is some combination of size and speed can do their own computations based on these two values. Resolves dotnet#96878.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the perf score a pure performance metric. Size is emitted as a separate metric, so clients interested in a metric that is some combination of size and speed can do their own computations based on these two values.
Resolves #96878.