Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure syncblock is cleared with GC_ALLOC_ZEROING_OPTIONAL #97174

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Ensure syncblock is cleared with GC_ALLOC_ZEROING_OPTIONAL #97174

merged 2 commits into from
Jan 19, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jan 18, 2024

Fixes #96790

@ghost ghost assigned jkotas Jan 18, 2024
@jkotas jkotas requested a review from cshung January 18, 2024 19:35
@jkotas jkotas mentioned this pull request Jan 18, 2024
Closed
jkotas
jkotas commented Jan 18, 2024
View reviewed changes
src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved
This was referenced Jan 18, 2024
Open
Closed
cshung
cshung approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@cshung cshung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jkotas jkotas merged commit 59a38f1 into dotnet:main Jan 19, 2024
109 of 111 checks passed
@jkotas jkotas deleted the issue-96790 branch January 19, 2024 03:09
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@jkotas @tmds
Ensure syncblock is cleared with GC_ALLOC_ZEROING_OPTIONAL (dotnet#97174
6c04b48 
)

Fixes dotnet#96790
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mangod9 mangod9 mangod9 left review comments

@cshung cshung cshung approved these changes

Assignees

@jkotas jkotas

Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assert failure: orObject->HasEmptySyncBlockInfo()
3 participants
@jkotas @cshung @mangod9