Add implementations for MakePointerType(), MakeArrayType() for GenericTypeParameterBuilder #97350

buyaa-n · 2024-01-22T22:34:02Z

Add implementations for MakePointerType(), MakeByRefType(), MakeArrayType() for GenericTypeParameterBuilderImpl
Needed to copy some internal API implementation for referencing SymbolType from System.Reflection.Emit
Add implementation for GetField(string name, BindingFlags bindingAttr) and GetFields(BindingFlags bindingAttr) for TypeBuilderImpl.
Fix bugs found in a broader testing, mostly related to generic type/methods validation and signature

Contributes to #92975

…cTypeParameterBuilder

ghost · 2024-01-22T22:34:18Z

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

Issue Details

Add implementations for MakePointerType(), MakeByRefType(), MakeArrayType() for GenericTypeParameterBuilderImpl
Needed to copy some internal API implementation for referencing SymbolType from System.Reflection.Emit
Add implementation for TypeBuilderImpl.GetField(string name, BindingFlags bindingAttr)

Author:	buyaa-n
Assignees:	-
Labels:	`area-System.Reflection.Emit`
Milestone:	-

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs

src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/SymbolType.cs

…nce, add more test and other implementations

...s/System.Private.CoreLib/src/System/Reflection/Emit/ConstructorOnTypeBuilderInstantiation.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ParameterBuilderImpl.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs

…ctorInfo reference, remove abstract method validation

jkotas · 2024-02-03T04:06:02Z

remove abstract method validation

Could you please add a test case for the implementing method and the abstract method with different return types, that I have shared with you on Teams? My guess is that the validation in ValidateImplementedMethod is still going to have a problem with it.

…eturning different type on method override

buyaa-n · 2024-02-05T20:38:13Z

remove abstract method validation

Could you please add a test case for the implementing method and the abstract method with different return types, that I have shared with you on Teams? My guess is that the validation in ValidateImplementedMethod is still going to have a problem with it.

Added test, it was indeed failing, thank you!

AaronRobinsonMSFT · 2024-02-05T22:25:57Z

...raries/System.Private.CoreLib/src/System/Reflection/Emit/MethodOnTypeBuilderInstantiation.cs

+                if (!IsGenericMethod)
+                {
+                    return false;
+                }


This defers to _method.IsGenericMethod, which seems close to _method.ContainsGenericParameters. Does the latter inform the former?

No, _method.ContainsGenericParameters could be true when method is not generic, but the containing type has any open generic parameter.

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/FieldBuilderImpl.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs

Co-authored-by: Aaron Robinson <arobins@microsoft.com>

…num type case

steveharter

Minor comments added, but otherwise fixes important issues. Thanks!

src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/SymbolType.cs

src/libraries/System.Reflection.Emit/src/Resources/Strings.resx

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ArrayMethod.cs

...braries/System.Reflection.Emit/src/System/Reflection/Emit/GenericTypeParameterBuilderImpl.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ModuleBuilderImpl.cs

.../System.Reflection.Emit/tests/PersistableAssemblyBuilder/AssemblySaveTypeBuilderAPIsTests.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ILGeneratorImpl.cs

buyaa-n · 2024-02-08T23:49:07Z

Failures unrelated and known

Add implementations for MakePointerType(), MakeArrayType() for Generi…

9365155

…cTypeParameterBuilder

buyaa-n requested review from jkotas, steveharter and AaronRobinsonMSFT January 22, 2024 22:34

dotnet-issue-labeler bot added the area-System.Reflection.Emit label Jan 22, 2024

ghost assigned buyaa-n Jan 22, 2024

AaronRobinsonMSFT reviewed Jan 22, 2024

View reviewed changes

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs Outdated Show resolved Hide resolved

jkotas reviewed Jan 22, 2024

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/SymbolType.cs Outdated Show resolved Hide resolved

Fix issue in loading constructed generic method, apply feedbacks

456dac8

This was referenced Jan 23, 2024

Tracking issue for CI build timeouts #76454

Closed

Tracking issue for "WORKLOAD TIMED OUT" #90309

Closed

Fix valdiations bugs, issue in constructed generic constuctor reference

5143dc6

buyaa-n force-pushed the generic_pointer branch from 3983557 to 5143dc6 Compare January 23, 2024 23:37

buyaa-n added 2 commits January 23, 2024 15:39

Merge branch 'main' of github.com:dotnet/runtime into generic_pointer

eccf74e

Fix more issues related to generic method/type validations and refere…

d07377c

…nce, add more test and other implementations

buyaa-n force-pushed the generic_pointer branch from 80122ec to d07377c Compare January 26, 2024 18:30

build-analysis bot mentioned this pull request Jan 26, 2024

"We stopped hearing from agent Azure Pipelines 32. Verify the agent machine is running and has a healthy network connection" dotnet/dnceng#1886

Open

3 tasks

buyaa-n requested review from jkotas and AaronRobinsonMSFT January 29, 2024 18:18

jkotas reviewed Jan 29, 2024

View reviewed changes

...s/System.Private.CoreLib/src/System/Reflection/Emit/ConstructorOnTypeBuilderInstantiation.cs Outdated Show resolved Hide resolved

AaronRobinsonMSFT reviewed Jan 29, 2024

View reviewed changes

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ParameterBuilderImpl.cs Outdated Show resolved Hide resolved

AaronRobinsonMSFT reviewed Jan 29, 2024

View reviewed changes

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs Outdated Show resolved Hide resolved

AaronRobinsonMSFT reviewed Jan 29, 2024

View reviewed changes

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs Show resolved Hide resolved

buyaa-n added 2 commits January 29, 2024 16:58

Apply feedbacks

11b7abf

Fix bug with setting constant value for a enum field

20fc24d

This was referenced Jan 31, 2024

Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637

Open

Assertion failed 'hwintrinsicChild->isContained()' in 'System.Numerics.Tensors.TensorPrimitives+ScaleBOperator #97688

Closed

Add MethodBuilder.GetArrayMethodCore(...) implementation

d11e06c

build-analysis bot mentioned this pull request Feb 1, 2024

System.IO.Tests.File_GetSetTimes_SafeFileHandle.WritingShouldUpdateWriteTime_After_SetLastAccessTime failing #97020

Open

Fix bug in Array method, MethodOnTypeBuilderInstantiation and Constru…

80acc53

…ctorInfo reference, remove abstract method validation

This was referenced Feb 3, 2024

Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049

Closed

[browser][MT] Unhandled JS error #97546

Closed

System.Net.Security.Tests.SslStreamCertificateContextOcspLinuxTests.RefreshOcspResponse_BeforeExpiration test failure #97779

Closed

Fix token issue with nested generic type, add test for derived type r…

184f85e

…eturning different type on method override

buyaa-n requested review from jkotas and AaronRobinsonMSFT February 5, 2024 21:53

AaronRobinsonMSFT reviewed Feb 5, 2024

View reviewed changes

buyaa-n mentioned this pull request Feb 6, 2024

What's new in .NET 9 Preview 1 dotnet/core#9089

Closed

buyaa-n and others added 2 commits February 5, 2024 17:39

Apply suggestions from code review

256b3a2

Co-authored-by: Aaron Robinson <arobins@microsoft.com>

Use ActiveIssue attribute for failing test on mono, add comment for e…

d68d676

…num type case

steveharter approved these changes Feb 7, 2024

View reviewed changes

Apply feedbacks

199b124

dotnet deleted a comment from buyaa-n Feb 8, 2024

build-analysis bot mentioned this pull request Feb 8, 2024

PortableSourceBuild failures in runtime-dev-innerloop #98160

Closed

Added comment was not saved with previous commit

3738891

jkotas reviewed Feb 8, 2024

View reviewed changes

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ILGeneratorImpl.cs Outdated Show resolved Hide resolved

Rename Get***Handle methods into TryGet***Handle

62edee7

buyaa-n merged commit e87d5d9 into dotnet:main Feb 8, 2024
172 of 178 checks passed

buyaa-n deleted the generic_pointer branch February 8, 2024 23:50

This was referenced Feb 9, 2024

System.Net.Security.Tests.SslStreamCertificateContextOcspLinuxTests.FetchOcspResponse_FirstInvalidThenValid test failure #97836

Closed

[browser][MT] HttpClientCancelTest.SendAsync_Cancel_Success #98201

Closed

This was referenced Feb 15, 2024

System.Reflection.Emit.AssemblyBuilder.Save #15704

Closed

Tracking issue for remaining AssemblyBuilder.Save work in .NET 9 #92975

Closed

github-actions bot locked and limited conversation to collaborators Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add implementations for MakePointerType(), MakeArrayType() for GenericTypeParameterBuilder #97350

Add implementations for MakePointerType(), MakeArrayType() for GenericTypeParameterBuilder #97350

buyaa-n commented Jan 22, 2024 •

edited

Loading

ghost commented Jan 22, 2024

jkotas commented Feb 3, 2024 •

edited

Loading

buyaa-n commented Feb 5, 2024

AaronRobinsonMSFT Feb 5, 2024

buyaa-n Feb 6, 2024

steveharter left a comment

buyaa-n commented Feb 8, 2024

Add implementations for MakePointerType(), MakeArrayType() for GenericTypeParameterBuilder #97350

Add implementations for MakePointerType(), MakeArrayType() for GenericTypeParameterBuilder #97350

Conversation

buyaa-n commented Jan 22, 2024 • edited Loading

ghost commented Jan 22, 2024

jkotas commented Feb 3, 2024 • edited Loading

buyaa-n commented Feb 5, 2024

AaronRobinsonMSFT Feb 5, 2024

Choose a reason for hiding this comment

buyaa-n Feb 6, 2024

Choose a reason for hiding this comment

steveharter left a comment

Choose a reason for hiding this comment

buyaa-n commented Feb 8, 2024

buyaa-n commented Jan 22, 2024 •

edited

Loading

jkotas commented Feb 3, 2024 •

edited

Loading