JIT: Merge fgRemoveConditionalJump and fgOptimizeBranchToNext #97456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsAdding this back in after #97407.
|
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Small improvements from slightly more aggressive statement removal. |
Diff results for #97456Assembly diffsAssembly diffs for linux/arm64 ran on windows/x64Diffs are based on 2,501,157 contexts (1,003,806 MinOpts, 1,497,351 FullOpts). MISSED contexts: 4,060 (0.16%) Overall (-60 bytes)
FullOpts (-60 bytes)
Assembly diffs for linux/x64 ran on windows/x64Diffs are based on 2,595,007 contexts (1,052,329 MinOpts, 1,542,678 FullOpts). MISSED contexts: 3,628 (0.14%) Overall (-1,818 bytes)
FullOpts (-1,818 bytes)
Assembly diffs for osx/arm64 ran on windows/x64Diffs are based on 2,262,709 contexts (930,876 MinOpts, 1,331,833 FullOpts). MISSED contexts: 3,256 (0.14%) Overall (-60 bytes)
FullOpts (-60 bytes)
Assembly diffs for windows/arm64 ran on windows/x64Diffs are based on 2,318,207 contexts (931,543 MinOpts, 1,386,664 FullOpts). MISSED contexts: 2,687 (0.12%) Overall (-100 bytes)
FullOpts (-100 bytes)
Assembly diffs for windows/x64 ran on windows/x64Diffs are based on 2,492,912 contexts (983,689 MinOpts, 1,509,223 FullOpts). MISSED contexts: 3,899 (0.16%) Overall (-1,531 bytes)
FullOpts (-1,531 bytes)
Details here Assembly diffs for linux/arm ran on windows/x86Diffs are based on 2,237,690 contexts (827,812 MinOpts, 1,409,878 FullOpts). MISSED contexts: 74,588 (3.23%) Overall (-1,314 bytes)
FullOpts (-1,314 bytes)
Assembly diffs for windows/x86 ran on windows/x86Diffs are based on 2,296,277 contexts (841,817 MinOpts, 1,454,460 FullOpts). MISSED contexts: 5,093 (0.22%) Overall (-1,067 bytes)
FullOpts (-1,067 bytes)
Details here Throughput diffsThroughput diffs for linux/arm ran on windows/x86Overall (-0.01% to -0.00%)
FullOpts (-0.01% to -0.00%)
Details here |
|
cc @dotnet/jit-contrib, bumping this since the diffs in #97488 are skewed without it. |
AndyAyersMS
approved these changes
Jan 26, 2024
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this back in after #97407.
fgRemoveConditionalJumpandfgOptimizeBranchToNextdo the same thing, except that the latter explicitly assumes the false target of theBBJ_CONDblock being optimized is the next block. It makes sense to remove that assumption, and merge these methods before allowing the false target to diverge from the next block during flowgraph optimization phases.