Add support for Vector<T>.Indices and Vector.CreateSequence #97880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics Issue DetailsThis covers the xplat APIs approved in #94008
|
stephentoub
reviewed
Feb 2, 2024
| @@ -596,6 +597,7 @@ public partial struct Vector4 : System.IEquatable<System.Numerics.Vector4>, Syst | |||
| public Vector(T[] values, int index) { throw null; } | |||
| public static System.Numerics.Vector<T> AllBitsSet { get { throw null; } } | |||
| public static int Count { get { throw null; } } | |||
| public static System.Numerics.Vector<T> Indices { get { throw null; } } | |||
There was a problem hiding this comment.
Can we use this here?
There was a problem hiding this comment.
There are several places that this should be usable including in LINQ and in Tensors
However, I was going to put up an issue and cover them in a follow up PR since source.dot.net wasn't bringing them up at the moment (making finding all the places rather difficult): https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/System/Numerics/Vector_1.cs,2157880a86aea82e,references
Diff results for #97880Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64MinOpts (-0.00% to +0.01%)
Throughput diffs for windows/x64 ran on windows/x64Overall (+0.00% to +0.01%)
FullOpts (-0.00% to +0.01%)
Details here |
Diff results for #97880Throughput diffsThroughput diffs for windows/arm64 ran on windows/x64MinOpts (-0.01% to +0.00%)
Throughput diffs for windows/x64 ran on windows/x64Overall (+0.00% to +0.01%)
FullOpts (+0.00% to +0.01%)
Details here Throughput diffs for windows/x86 ran on windows/x86FullOpts (+0.00% to +0.01%)
Details here |
tannergooding
force-pushed
the
createseq
branch
from
b282804 to
b93a3a5
Compare
Diff results for #97880Throughput diffsThroughput diffs for linux/arm64 ran on linux/x64MinOpts (-0.00% to +0.01%)
Throughput diffs for windows/arm64 ran on linux/x64MinOpts (0.00% to +0.01%)
Throughput diffs for windows/x64 ran on linux/x64Overall (+0.00% to +0.01%)
FullOpts (+0.00% to +0.01%)
Details here |
tannergooding
force-pushed
the
createseq
branch
from
b93a3a5 to
3e214a8
Compare
Diff results for #97880Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64MinOpts (-0.00% to +0.01%)
Throughput diffs for windows/arm64 ran on windows/x64MinOpts (0.00% to +0.01%)
Throughput diffs for windows/x64 ran on windows/x64Overall (+0.00% to +0.01%)
FullOpts (+0.00% to +0.01%)
Details here |
This was referenced Feb 3, 2024
Diff results for #97880Throughput diffsThroughput diffs for windows/arm64 ran on linux/x64MinOpts (-0.01% to +0.00%)
Throughput diffs for windows/x64 ran on linux/x64Overall (+0.00% to +0.01%)
FullOpts (+0.00% to +0.01%)
Details here |
tannergooding
force-pushed
the
createseq
branch
from
3e214a8 to
971e475
Compare
Diff results for #97880Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64MinOpts (-0.01% to +0.00%)
Throughput diffs for windows/arm64 ran on windows/x64MinOpts (-0.01% to +0.00%)
Throughput diffs for windows/x64 ran on windows/x64Overall (+0.00% to +0.01%)
FullOpts (+0.00% to +0.01%)
Details here |
tannergooding
force-pushed
the
createseq
branch
from
971e475 to
db75184
Compare
This was referenced Feb 3, 2024
|
ping @dotnet/jit-contrib, this is ready for review and is a simple change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the xplat APIs approved in #94008