-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update solution files after projects changes #97969
Conversation
The project files have now diferent dependencies
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsThe project files have now different dependencies
|
@ViktorHofer I used the slngen.proj to update these solution files. I noticed you updated solution files in the past too, do you know if that is the preferred way to do it? @pavelsavara does the build work for you with these changes? |
Yes. |
It's better/different problem now.
Build will pass. |
Note the error is pointing to CoreCLR files, but we need Mono. |
Yes, from different folder, so my cmd line was Then I picked only the solution files affected by the previous PR changes. |
You will need to tell VS that. By default, CoreCLR is used. @akoeplinger do we already have an established pattern to link to the Mono's Private.CoreLib inside VS? I was suggesting to set
This indicates that something tries to invoke the task before the project references are built. ILLink.Tasks.csproj should be a project reference dependency and automatically get built. |
We usually update all solution files but we can do that in a separate PR. |
I'm not sure anyone tried, but setting RuntimeFlavor sounds like worth a try. Though thinking about it, shouldn't VS compile against the ref SPC, not the implementation? |
In this case we need the implementation, as it uses the |
Projects compile against ref/CoreLib but they (correctly) reference the src/CoreLib project which then references the ref/CoreLib.
We could respect that switch in build.ps1. #97975 |
This helped with the |
I reran slngen locally, opened the produced slns and the failure from the picture above is now gone. No idea what is different but I updated your branch with the file updates. |
I'm good now, passing
Edit, it must be env variables not |
Merging as slns aren't exercised in CI anyway. |
Follow-ups. Filed #97984 to track Platform not being passed in correctly to System.Private.CoreLib's build. Submitted #97982 to respect the -os and -arch build properties for the VS invocation. Submitted #97974 to not cause task locks and to not trigger the illink tasks for CoreLib's build when opening VS and doing a design time build. |
The project files have now different dependencies after changes in #97052