Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass --os inferred from TargetRID unless Short Stack #98381

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Don't pass --os inferred from TargetRID unless Short Stack #98381

merged 2 commits into from
Feb 13, 2024

Conversation

directhex
Copy link
Contributor

Closes: #98364

@ghost ghost assigned directhex Feb 13, 2024
@ghost
Copy link

ghost commented Feb 13, 2024

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes: #98364

Author: directhex
Assignees: directhex
Labels:

area-Infrastructure-libraries
Milestone: -

ViktorHofer
ViktorHofer approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the right condition is "DotNetBuildSourceOnly != True" though.

@build-analysis build-analysis bot mentioned this pull request Feb 13, 2024
Closed
@akoeplinger akoeplinger merged commit 1781891 into dotnet:main Feb 13, 2024
177 of 180 checks passed
@build-analysis build-analysis bot mentioned this pull request Feb 14, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees

@directhex directhex

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

banana24SourceBuild and centos8SourceBuild are broken in runtime rolling pipeline
3 participants
@directhex @akoeplinger @ViktorHofer