Fix deadlock when we request a ReJIT due to an inlined method #98400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon Issue DetailsBy holding the CodeVersionManager and then calling ReJIT lock we set ourselves up for a deadlock with a ReJIT thread which grabs the ReJIT lock first and then tries to get the CodeVersionManager lock to publish the new IL. Fixes #97771
|
mdh1418
approved these changes
Feb 14, 2024
hoyosjs
approved these changes
Feb 14, 2024
davmason
commented
Feb 14, 2024
noahfalk
approved these changes
Feb 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By holding the CodeVersionManager and then calling ReJIT lock we set ourselves up for a deadlock with a ReJIT thread which grabs the ReJIT lock first and then tries to get the CodeVersionManager lock to publish the new IL.
Fixes #97771