Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILLlink] In DIM finding, exit early if the interface doesn't impl the DIM we're looking for #98436

Closed
wants to merge 3 commits into from
Closed

[ILLlink] In DIM finding, exit early if the interface doesn't impl the DIM we're looking for #98436

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50c6167
Exit early if the interface doesn't impl the DIM we're looking for
jtschuster Feb 14, 2024
733f645
Merge branch 'main' into FindDIMsFaster
jtschuster Feb 14, 2024
2df8dbf
Use foreach instead of Any()
jtschuster Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/tools/illink/src/linker/Linker/TypeMapInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
using System.Collections.Generic;
using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Linq;
using Mono.Cecil;

namespace Mono.Linker
Expand Down Expand Up @@ -293,6 +294,10 @@ void FindAndAddDefaultInterfaceImplementations (TypeDefinition type, MethodDefin
if (potentialImplInterface == null)
continue;

// If the interface doesn't implement the interface with the method we're looking for, exit early
if (!potentialImplInterface.Interfaces.Any(i => context.TryResolve(i.InterfaceType) == interfaceMethod.DeclaringType))
continue;

bool foundImpl = false;

foreach (var potentialImplMethod in potentialImplInterface.Methods) {
Expand Down
Loading