-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move out globalization code from runtime #98495
Conversation
Tagging subscribers to this area: @dotnet/area-system-globalization Issue Detailsnull
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
Azure Pipelines successfully started running 3 pipeline(s). |
If the code in native-library.c is removed, how are these pinvoke methods going to be resolved ? |
|
This is in the CoreCLR code-base, which isn't used by Mono at all. The code you removed in native-library.c is the equivalent code in Mono. |
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
Azure Pipelines successfully started running 3 pipeline(s). |
@lewing @akoeplinger could you please review |
We can now use __typeof__ in recent MSVC and some small tweaks to how the function pointers are defined. Also fix the PDB not getting copied next to the .dll and disable validating the .so file which doesn't apply to Windows.
76b4841
to
ab25074
Compare
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Failures are not related. |
Currently we compile the globalization code twice:
By this PR we will move the globalization code out of the mono runtime.