Add correct ImplementingType and InterfaceImpl to DIM cache in TypeMapInfo #98513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #98436 (comment)
We don't add the correct
ImplementingType
to the DIM's cache. Instead we can pass the correct implementing type toFindAndAddDefaultInterfaceImplementations
. This worked fine for assemblies compiled by Roslyn because it adds an InterfaceImpl for all transitive interfaces, but IL doesn't require that.Test cases for this require types that don't have interfaceimpls for all their interfaces directly on their type, but that also fails for another reason: #98536. Test cases in #98540 should cover both issues.