[mono] Intrinsify multiple StoreVector API's #98514
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
src/mono/mono/mini/simd-intrinsics.c
Outdated
|
|
||
| MonoClass* value = mono_class_from_mono_type_internal (fsig->params [1]); | ||
|
|
||
| MonoInst* ins = emit_simd_ins_for_sig (cfg, klass, OP_ARM64_STM, opcode, arg0_type, fsig, args); |
There was a problem hiding this comment.
You could pass value as the second argument for emit_simd_ins_for_sig and get rid of the next line. Although value is kinda generic. Maybe rename it to klass_tuple_var or something else with more information.
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics Issue DetailsContributes to #93081 This PR intrinsifies the following API's: AdvSimd.StoreVector64x*
|
jkurdek
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
src/mono/mono/mini/simd-intrinsics.c
Outdated
| case SN_StoreVector64x2AndZip: | ||
| case SN_StoreVector64x3AndZip: | ||
| case SN_StoreVector64x4AndZip: { | ||
| int opcode = 0; |
There was a problem hiding this comment.
Usually we consider OP_ARM64_STM as the opcode. I would prefer to rename this variable as intrinsics_id or iid
Contributes to #93081
This PR intrinsifies the following APIs:
AdvSimd.StoreVector64x*
AdvSimd.Arm64.StoreVector128x*
AdvSimd.StoreVector64xAndZip
AdvSimd.Arm64.StoreVector128xAndZip