Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Intrinsify LoadAndInsertScalar #98532

Merged

Conversation

fanyang-mono
Copy link
Member

Contributes to #93081

This PR intrinsify the following API's:

  • AdvSimd.LoadAndInsertScalar
  • AdvSimd.Arm64.LoadAndInsertScalar

Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Feb 16, 2024

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #93081

This PR intrinsify the following API's:

  • AdvSimd.LoadAndInsertScalar
  • AdvSimd.Arm64.LoadAndInsertScalar
Author: fanyang-mono
Assignees: fanyang-mono
Labels:

area-System.Runtime.Intrinsics, new-api-needs-documentation

Milestone: -

Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as tests are passing locally.

@fanyang-mono
Copy link
Member Author

fanyang-mono commented Feb 16, 2024

Runtime tests passed when running locally:

Supported ISAs:
  AdvSimd:   True
  Aes:       True
  ArmBase:   True
  Crc32:     True
  Dp:        False
  Rdm:       False
  Sha1:      True
  Sha256:    True
  Sve:       False
......
Expected: 100
Actual: 100
END EXECUTION - PASSED

@fanyang-mono fanyang-mono merged commit 8229e00 into dotnet:main Feb 16, 2024
185 of 189 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants