-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Update diasymreader to 17.8.7-beta1.24113.1 #98539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will take for consideration in 8.0.x
Tagging subscribers to this area: @tommcdon Issue DetailsUpdate version of diasymreader to 17.8.7-beta1.24113.1 Customer ImpactThis comes from a request of the Roslyn team as newer reader is needed to emit toolset information into debug streams. This aligns the toolset with best practices for supply chain and is needed for LTS use of the toolchain. Regression
Testing
RiskModerate. The following areas use this library:
|
Wrong milestone (applied on Feb 20th). Code Complete for 8.0.3 was on Feb 12th. This will have to go to 8.0.4 if merged before the next Code Complete (March 11th). |
Failure reproduced in other staging PR's. Run too old to rerun: let failedTests = (methodName : string, includePR : bool, messageSubstr: string, includePassedOnRerun : bool) {
cluster('engsrvprod.kusto.windows.net').database('engineeringdata').AzureDevOpsTests
| where TestName startswith "System.Net"
| where includePassedOnRerun or (Outcome == 'Failed')
| extend startOfTestName = indexof_regex(TestName, @"[^.]+$")
| extend Method = substring(TestName, startOfTestName)
| extend Type = substring(TestName, 0, startOfTestName - 1)
| project-away startOfTestName
| where Method == methodName
| where Message contains messageSubstr
| distinct JobId, WorkItemId, Message, StackTrace, Method, Type, Arguments, Outcome
| join kind=inner (cluster('engsrvprod.kusto.windows.net').database('engineeringdata').Jobs
| where ((Branch == 'refs/heads/main') or (Branch == 'refs/heads/master') or (includePR and (Source startswith "pr/")))
| where Type startswith "test/functional/cli/"
and not(Properties contains "runtime-staging")
| summarize arg_max(Finished, Properties, Type, Branch, Source, Started, QueueName) by JobId
| project-rename JobType = Type) on JobId
| extend PropertiesJson = parse_json(Properties)
| extend OS = replace_regex(tostring(PropertiesJson.operatingSystem), @'\((.*)\).*|([^\(].*)', @'\1\2')
| extend Runtime = iif(PropertiesJson.runtimeFlavor == "mono", "Mono", iif(PropertiesJson.DefinitionName contains "coreclr", "CoreCLR", ""))
| extend TargetBranch = extractjson("$.['System.PullRequest.TargetBranch']", Properties)
| extend Architecture = PropertiesJson.architecture
| extend Scenario = iif(isempty(PropertiesJson.scenario), "--", PropertiesJson.scenario)
//| extend DefinitionName = PropertiesJson.DefinitionName
| project-away PropertiesJson
};
failedTests('ConnectWithRevocation_WithCallback', true, 'An unknown chain building error occurred', true); |
Update version of diasymreader to 17.8.7-beta1.24113.1
Customer Impact
This comes from a request of the Roslyn team as newer reader is needed to emit toolset information into debug streams. This aligns the toolset with best practices for supply chain and is needed for LTS use of the toolchain.
Regression
Testing
Risk
Moderate. The following areas use this library: