Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] JSType.OneWay -> JSType.DiscardNoWait #98647

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[browser][MT] JSType.OneWay -> JSType.DiscardNoWait #98647

merged 1 commit into from
Feb 19, 2024

Conversation

pavelsavara
Copy link
Member

and other feedback from @kg in #98567

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Feb 19, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Feb 19, 2024
@pavelsavara pavelsavara requested review from kg and maraf February 19, 2024 08:57
@pavelsavara pavelsavara self-assigned this Feb 19, 2024
@ghost
Copy link

ghost commented Feb 19, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

and other feedback from @kg in #98567

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

kg
kg approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too sleepy to properly review marshal.ts, but everything else looks good.

@pavelsavara pavelsavara merged commit 2df0ad1 into dotnet:main Feb 19, 2024
118 of 122 checks passed
@pavelsavara pavelsavara deleted the kg_feedback branch February 19, 2024 10:52
@build-analysis build-analysis bot mentioned this pull request Feb 19, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@kg kg kg approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @kg @maraf