Expanded & clarified BerConverter tests #98676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should demonstrate how to properly decode using the "v" format string
ber_printf will always write a series of octet strings if passed a string[] with the "v" or "V" format strings. ber_scanf expects an ASN.1 SEQUENCE OF octet strings.
|
Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014 Issue DetailsRelates to #97540. I've added comments highlighting the actual and the expected data structures of each decoding test. There's asymmetry in ber_printf and ber_scanf for the "v" and "V" format strings, so I've added a new test case to highlight that and to demonstrate the correct encoding & decoding format strings.
|
This was referenced Feb 19, 2024
The latter doesn't match my computer, but the difference appears to be coming from within the underlying ber_scanf library so I can't investigate further.
This was referenced Feb 20, 2024
buyaa-n
approved these changes
Mar 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #97540.
I've added comments highlighting the actual and the expected data structures of each decoding test. There's asymmetry in ber_printf and ber_scanf for the "v" and "V" format strings, so I've added a new test case to highlight that and to demonstrate the correct encoding & decoding format strings.