[mono][aot] Add a 'compile-in-child' AOT argument #98866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
/azp run runtime-wasm,runtime-ioslike |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-wasm,runtime-ioslike |
|
Azure Pipelines successfully started running 2 pipeline(s). |
vargaz
changed the title
|
/azp run runtime-wasm,runtime-ioslike |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-wasm,runtime-ioslike |
|
Azure Pipelines successfully started running 2 pipeline(s). |
vargaz
force-pushed
the
aot-driver
branch
2 times, most recently
from
1b33ed8 to
997d955
Compare
|
/azp run runtime-wasm,runtime-ioslike |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-wasm,runtime-ioslike |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-wasm,runtime-ioslike |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Feb 25, 2024
|
Azure Pipelines successfully started running 2 pipeline(s). |
akoeplinger
reviewed
Mar 1, 2024
|
/azp run runtime-wasm,runtime-ioslike |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-wasm,runtime-ioslike |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-wasm,runtime-ioslike |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Failures are unrelated. |
steveisok
approved these changes
Mar 2, 2024
|
Enabling this on wasm on windows causes test failures, but the linux version seems to work. |
When set, the JIT compilation is done in a child process. This helps to reduce overall memory usage since memory used during JITting is no longer going to be reserved when running external tools like opt/llc.
radical
pushed a commit
to radical/runtime
that referenced
this pull request
Mar 6, 2024
* [mono][aot] Collect command line arguments and pass them to the aot compiler. * [mono][aot] Extract the code invoking external tools into separate functions. * [mono][aot] Add a 'compile-in-child' aot argument. When set, the JIT compilation is done in a child process. This helps to reduce overall memory usage since memory used during JITting is no longer going to be reserved when running external tools like opt/llc. * Enable by default on wasm on unix. * Handle spaces correctly. * Disable on windows for now. * Add dedup support. * Add windows support. * Enable on wasm on windows. * Fix windows support. * Disable on windows.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set, the JIT compilation is done in a child process. This helps to reduce overall memory usage since memory used during JITting is no longer going to be reserved when running external tools like opt/llc.