[RISC-V] Add missing jumpTable increment #98992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After dotnet#98671 we noticed that some of coreclr tests started crashing because of infinite recursion seen like: root@3b821d4a686a:/runtime/artifacts/tests/coreclr/linux.riscv64.Checked/CoreMangLib/system/buffer/ASURT_99893# $CORE_ROOT/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true ASURT_99893.dll '' Process terminated. Encountered infinite recursion while looking up resource 'Arg_ResourceFileUnsupportedVersion' in System.Private.CoreLib. Verify the installation of .NET is complete and does not need repairing, and that the state of the process has not become corrupted. at System.Environment.FailFast(System.String) at System.SR.InternalGetResourceString(System.String) at System.SR.GetResourceString(System.String) at System.SR.get_Arg_ResourceFileUnsupportedVersion() at System.Resources.ResourceReader._ReadResources() at System.Resources.ResourceReader.ReadResources() at System.Resources.ResourceReader..ctor(System.IO.Stream, System.Collections.Generic.Dictionary`2<System.String,System.Resources.ResourceLocator>, Boolean) at System.Resources.RuntimeResourceSet..ctor(System.IO.Stream, Boolean) at System.Resources.ManifestBasedResourceGroveler.CreateResourceSet(System.IO.Stream, System.Reflection.Assembly) at System.Resources.ManifestBasedResourceGroveler.GrovelForResourceSet(System.Globalization.CultureInfo, System.Collections.Generic.Dictionary`2<System.String,System.Resources.ResourceSet>, Boolean, Boolean) at System.Resources.ResourceManager.InternalGetResourceSet(System.Globalization.CultureInfo, Boolean, Boolean) at System.Resources.ResourceManager.GetString(System.String, System.Globalization.CultureInfo) at System.SR.InternalGetResourceString(System.String) at System.SR.GetResourceString(System.String) at System.SR.get_Arg_ResourceFileUnsupportedVersion() at System.Resources.ResourceReader._ReadResources() at System.Resources.ResourceReader.ReadResources() at System.Resources.ResourceReader..ctor(System.IO.Stream, System.Collections.Generic.Dictionary`2<System.String,System.Resources.ResourceLocator>, Boolean) at System.Resources.RuntimeResourceSet..ctor(System.IO.Stream, Boolean) at System.Resources.ManifestBasedResourceGroveler.CreateResourceSet(System.IO.Stream, System.Reflection.Assembly) at System.Resources.ManifestBasedResourceGroveler.GrovelForResourceSet(System.Globalization.CultureInfo, System.Collections.Generic.Dictionary`2<System.String,System.Resources.ResourceSet>, Boolean, Boolean) This change fixes issue by adding missing jumpTable increment.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsAfter #98671 we noticed that some of coreclr tests started crashing because of infinite recursion seen like: This change fixes issue by adding missing jumpTable increment. Part of #84834
|
Bajtazar
approved these changes
Feb 27, 2024
tomeksowi
approved these changes
Feb 27, 2024
gbalykov
approved these changes
Feb 27, 2024
amanasifkhalid
approved these changes
Feb 27, 2024
t-mustafin
approved these changes
Feb 27, 2024
sirntar
approved these changes
Feb 27, 2024
This was referenced Feb 27, 2024
wscho77
approved these changes
Feb 27, 2024
clamp03
approved these changes
Feb 27, 2024
JongHeonChoi
approved these changes
Feb 28, 2024
|
@jakobbotsch: Thanks for merging! I have suggestion of very simple follow-up PR. Currently we have five CodeGen::genJumpTable functions that contains exactly same code iterating over jump tables (~80% of whole genJumpTable). If you agree, I could extract that code to one common function and reduce possibility of introducing similar bugs in future. |
|
Sure, if you're able to factor out common code then we'd happily a PR that does that (provided the replacement doesn't just come with ifdef soup :-)). codegencommon.cpp would be a good place to put it I think. |
yurai007
added a commit
to yurai007/runtime
that referenced
this pull request
Feb 29, 2024
Moving same code used across all architectures to common codegen should simplify things and reduce possibility of future regressions as noted in dotnet#98992.
jakobbotsch
pushed a commit
that referenced
this pull request
Feb 29, 2024
Moving same code used across all architectures to common codegen should simplify things and reduce possibility of future regressions as noted in #98992.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #98671 we noticed that some of coreclr tests started crashing because of infinite recursion seen like:
This change fixes issue by adding missing jumpTable increment.
Part of #84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @brucehoult @sirntar @yurai007 @Bajtazar @bartlomiejko @rzsc @tomeksowi @amanasifkhalid