Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable IPV6 cases of QuicConnectionTests.TestConnect on non-ipv6 systems #98999

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Disable IPV6 cases of QuicConnectionTests.TestConnect on non-ipv6 systems #98999

merged 2 commits into from
Feb 29, 2024

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Feb 27, 2024

I am not sure why the ::1 address is included in LocalAddresses if system does not support IPv6, but we do similar filtering of IPv6 addresses in other tests.

@ghost ghost assigned rzikm Feb 27, 2024
@ghost
Copy link

ghost commented Feb 27, 2024

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

I am not sure why the ::1 address is included in LocalAddresses if system does not support IPv6, but we do similar filtering of IPv6 addresses in other tests.

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net
Milestone: -

@wfurt
Copy link
Member

wfurt commented Feb 27, 2024

I think there is fine line. Socket.OSSupportsIPv6 checks that the IPv6 Socket can be created. It does not mean loopback interface is configured.
I would probably prefer to fix the LocalAddresses than this particulate test.

This was referenced Feb 27, 2024
Closed
Closed
Closed
Closed
@rzikm rzikm requested a review from a team February 28, 2024 13:40
@ghost
Copy link

ghost commented Feb 28, 2024

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

I am not sure why the ::1 address is included in LocalAddresses if system does not support IPv6, but we do similar filtering of IPv6 addresses in other tests.

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net, area-System.Net.Quic
Milestone: -

@rzikm
Copy link
Member Author

rzikm commented Feb 29, 2024

CI Failures are unrelated

@rzikm rzikm merged commit 806d11e into dotnet:main Feb 29, 2024
108 of 111 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@antonfirsov antonfirsov antonfirsov approved these changes

Assignees

@rzikm rzikm

Labels
area-System.Net.Quic
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rzikm @wfurt @stephentoub @antonfirsov @karelz