[release/9.0-preview2] Disable the new exception handling by default again #99067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The new EH was enabled by default right before we've snapped for preview 2, but the various nightly CI tests that were executed after has uncovered a couple of issues that I've never seen before. I've fixed two of them, but another one has surfaced today, this time a GC hole that seems to be related to the new EH. Since there is no time left for inverstigating and fixing that for preview 2, I am disabling it by default again.
janvorli
added
Servicing-consider
jkotas
approved these changes
Feb 28, 2024
4 tasks
jeffschwMSFT
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #99066 to release/9.0-preview2
/cc @janvorli
Customer Impact
The new EH was enabled by default right before we've snapped for preview 2, but there were couple of issues that stemmed from it. I've fixed most of them, but aspnet has one that needs to be investigated and there is no more time left for preview 2.
Regression
#98570 - enables the new exception handling by default.
Testing
Local testing showing that the new EH is disabled.
Risk
Low, disables all the new EH stuff, no other thing is changed.