JIT: ARM64 SVE format encodings, SVE_BX_2A and SVE_BY_2A
#99087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsContributes to #94549 Adds formats:
Left: Capstone
|
|
@dotnet/jit-contrib @dotnet/arm64-contrib @a74nh @amanasifkhalid this is ready. |
| assert(isVectorRegister(id->idReg1())); | ||
| assert(isVectorRegister(id->idReg2())); | ||
| assert(isScalableVectorSize(elemsize)); | ||
| #ifdef DEBUG |
There was a problem hiding this comment.
don't think you need #ifdef DEBUG here. All these has is assert and compiler should be able to eliminate it.
There was a problem hiding this comment.
Yea, this has been commented about before. Personally, I like to have the ifdef for these situations as it distinguishes code that is for verification. Asserts on their own obviously don't need an ifdef, but for checks that require branching, I tend to wrap them around an ifdef.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #94549
Adds formats:
Left: Capstone
Right: Jit