Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GC hole in Guid #99138

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Fix GC hole in Guid #99138

merged 3 commits into from
Mar 7, 2024

Conversation

MichalPetryka
Copy link
Contributor

Found in #99130.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 1, 2024
@jkotas
Copy link
Member

jkotas commented Mar 1, 2024

Introduced by #87993

@ghost
Copy link

ghost commented Mar 1, 2024

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Found in #99130.

Author: MichalPetryka
Assignees: -
Labels:

area-System.Runtime, needs-area-label
Milestone: -

@jkotas jkotas added tenet-reliability Reliability/stability related issue (stress, load problems, etc.) and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 1, 2024
stephentoub
stephentoub approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@MichalPetryka
Copy link
Contributor Author

This needs a backport to .NET 8 FYI.

@hamarb123 hamarb123 mentioned this pull request Mar 1, 2024
Open
@MichalPetryka
Copy link
Contributor Author

@MihuBot

@MihuBot MihuBot mentioned this pull request Mar 2, 2024
Open
@MichalPetryka MichalPetryka mentioned this pull request Mar 2, 2024
Open
@MichalPetryka
Copy link
Contributor Author

@stephentoub Can this be merged now?

@build-analysis build-analysis bot mentioned this pull request Mar 7, 2024
Closed
@stephentoub stephentoub merged commit 1e3fe51 into dotnet:main Mar 7, 2024
176 of 178 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Runtime tenet-reliability Reliability/stability related issue (stress, load problems, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichalPetryka @jkotas @stephentoub