Skip to content

set scope and build validation in dev when no options provided #99199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 8, 2024
Merged

set scope and build validation in dev when no options provided #99199

merged 17 commits into from
Jul 8, 2024

Conversation

wcsanders1
Copy link
Contributor

Resolves issue #97091

@ghost
Copy link

ghost commented Mar 2, 2024

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info in area-owners.md if you want to be subscribed.

Issue Details

Resolves issue #97091

Author: wcsanders1
Assignees: -
Labels:

area-Extensions-Hosting
Milestone: -

@wcsanders1 wcsanders1 mentioned this pull request Mar 3, 2024
Closed
This was referenced Mar 3, 2024
Closed
Open
@build-analysis build-analysis bot mentioned this pull request Mar 5, 2024
Open
This was referenced Mar 6, 2024
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Mar 6, 2024
Closed
@steveharter steveharter self-requested a review March 7, 2024 21:33
steveharter
steveharter reviewed Mar 13, 2024
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Mar 14, 2024
Closed
This was referenced Apr 1, 2024
Closed
Closed
This was referenced Apr 12, 2024
Closed
Closed
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request May 2, 2024
Open
@buyaa-n
Copy link
Contributor

buyaa-n commented May 8, 2024

@benjaminpetit could you take a look please?

@steveharter steveharter merged commit 673a664 into dotnet:main Jul 8, 2024
@ericstj ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Jul 19, 2024
@dotnet-policy-service dotnet-policy-service bot added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Jul 19, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

dotnet-policy-service bot commented Jul 19, 2024 •
edited by ericstj
Loading

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@ericstj ericstj mentioned this pull request Jul 19, 2024
Closed
ericstj
ericstj reviewed Jul 19, 2024
View reviewed changes
src/libraries/Microsoft.Extensions.Hosting/src/HostBuilder.cs
public HostBuilder()
{
_serviceProviderFactory = new ServiceFactoryAdapter<IServiceCollection>(new DefaultServiceProviderFactory());
_defaultProviderFactoryUsed = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this ever set to false? Should that be done in UseServiceProviderFactory?

Copy link
Contributor Author

@wcsanders1 wcsanders1 Jul 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems to me that this field should be set to false when UseServiceProviderFactory is called. This was my oversight I believe.

@ericstj
Copy link
Member

ericstj commented Jul 19, 2024

I marked this PR as breaking since it introduces new validation by default when in Development environment.

@ericstj ericstj mentioned this pull request Jul 24, 2024
Merged
4 tasks
@ericstj
Copy link
Member

ericstj commented Jul 24, 2024 •
edited
Loading

@steveharter or @wcsanders1 can you please create a breaking change doc for the new defaults for ServiceProviderOptions in development? That will cover the case that we didn't undo here. It can mention that developers can workaround it using UseDefaultServiceProvider if they don't wish to run validation.

Update - I went ahead and created it, please review what I've created. dotnet/docs#41887

@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstj ericstj ericstj left review comments

@benjaminpetit benjaminpetit Awaiting requested review from benjaminpetit

@halter73 halter73 Awaiting requested review from halter73

+1 more reviewer

@steveharter steveharter steveharter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Extensions-Hosting breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wcsanders1 @buyaa-n @ericstj @steveharter