-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][MT] Marshal resolved/unresolved tasks separately #99347
[browser][MT] Marshal resolved/unresolved tasks separately #99347
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis change will avoid sending 2 messages to target thread (UI) and instead will only send one.
It could still happen that Task completion (on TP thread) is racing with the I'm not 100% sure why #99317 didn't help it. contributes to #98406
|
...e.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSProxyContext.cs
Outdated
Show resolved
Hide resolved
...aScript/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs
Outdated
Show resolved
Hide resolved
…stem/Runtime/InteropServices/JavaScript/JSProxyContext.cs Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
Filled #99395 |
CI issue is #98721 |
This change will avoid sending 2 messages to target thread (UI) and instead will only send one.
Otherwise will use new
JSAsyncTaskScheduler
mono_wasm_resolve_or_reject_promise_post
happens aftermono_wasm_invoke_jsimport_async_post
contributes to #98406