-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [release/8.0][browser] BrowserWebSocket.ReceiveAsync after server initiated close #99413
Conversation
Tagging subscribers to 'arch-wasm': @lewing |
a2059e1
to
1bb6a49
Compare
{ | ||
Assert.True(false, $"Unexpected exception: {e}"); | ||
} | ||
Assert.True(false, "Expected WebSocketException not thrown."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to Assert.Fail
when CI passes.
Today is code complete for the April Release. Please get a Tactics approval and merge this before 4pm PT, otherwise it will have to wait until the May Release. |
We are not ready to rush it in. |
Closing in favor of #99673. |
Follow up for #97002.