[release/6.0] Upgrade zlib to 1.3.1 #99475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"implicit-int-conversion" warning The change to deflate.c is legal because 'len' has an upper bound of MAX_STORED, which means it fits cleanly into a 16-bit integer. So writing out 2x 8-bit values will not result in data loss. The change to trees.c is legal because within this loop, 'count' is intended to have an upper bound of 138, with the target assignment only executing if 'count' is bounded by 4. Neither the 'count' local in isolation nor the addition that's part of the target line is expected to result in integer overflow. But even if it did, that's a matter for a different warning code and doesn't impact the correctness of the narrowing cast being considered here. Author: Levi Broderick <levib@microsoft.com>
This was referenced Mar 9, 2024
carlossanlop
commented
Mar 11, 2024
src/libraries/Native/Windows/System.IO.Compression.Native/zlib-version.txt
Outdated
Show resolved
Hide resolved
carlossanlop
added
the
Servicing-consider
carlossanlop
added
NO-MERGE
|
Approved by Tactics via email. |
carlossanlop
removed
the
NO-MERGE
GrabYourPitchforks
approved these changes
Mar 20, 2024
carlossanlop
merged commit c22b075
into
dotnet:release/6.0-staging
125 of 131 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #99472
Customer Impact
This is a required OSS update of our zlib library from version 1.2.13 (it has no CVEs) to the latest version, 1.3.1.
Regression
The 1.3.1 official release notes with the list of fixed bugs can be found here: https://github.com/madler/zlib/releases/tag/v1.3.1
Testing
Upstream unit testing in the official madler/zlib repo.
Our unit tests are also passing.
Risk
Very low.
Will merge the main PR first, then if no issues found on the next month, will merge this PR on Code Complete for the May Release (~mid April).